Finally! This feeling when the submission is accepted.
<insert celebration gif here, I do not know how to add gif in Medium post>
But reviewer still give some good feedbacks to my code :
- Give
alt
to images → related to accessibility - Move inline javascript to separate file (in
index.html
) - Use 3 chars comparison operators (better to use
===
than==
or better to use!==
than!=
) - Utilize existing classes on current css library
- Delete all unused files of current css library
- Using SVG, JPEG 2000, JPEG XR, and WebP to load images faster
One feedback that I don’t get it yet is Use const on variables that later require initiation and use let to initiate
Yeah, although code is accepted, it is better to review back the code and fix some minor things based on reviewer feedback. Nothing is perfect.
Different time, different detail of feedbacks. I think they have many reviewers in the course. As long as the minimal criteria / condition are passed.
I accept my rating is 4 of 5 stars.
Anyway, let’s continue the learning process. I have paid for this and have intention to finish this course as soon as possible. Based on this graph, I could finish it in 24 days or earlier.